[Bug 765431] aggregator: Check all pads for data when live

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Apr 22 20:41:29 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=765431

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326574|none                        |needs-work
             status|                            |

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 326574:
 --> (https://bugzilla.gnome.org/review?bug=765431&attachment=326574)

::: gst-libs/gst/base/gstaggregator.c
@@ +441,3 @@

+    /* Pad at EOS are considered having data, but not as first buffer */
+    if (!pad->priv->eos) {

Actually I'm uncertain that this is correct. I believe we could queue both data
and EOS, and we'd missed the first buffer ...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list