[Bug 764897] Using non IPv6-socket in IPv6 scope

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764897

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326686|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 326686:
 --> (https://bugzilla.gnome.org/review?bug=764897&attachment=326686)

::: gst/udp/gstmultiudpsink.c
@@ +1313,3 @@
     GST_DEBUG_OBJECT (sink, "using configured IPv6 socket");
+    g_return_val_if_fail (!sink->socket || (g_socket_get_family (sink->socket)
==
+        G_SOCKET_FAMILY_IPV6), FALSE);

This should be !=, not ==. It should fail if there is a ->socket and this
->socket is IPV6.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.