[Bug 760677] basesink: always drops buffers before segment

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760677

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Thiago Sousa Santos from comment #6)
> A downside is that render will be called for buffers that are late as well
> and the subclass wouldn't know about it. Perhaps we can add some new api
> like a drop_frame() method or some function to check if a buffer is late or
> not from the rendering function.

Some kind of is_late() function I'd say :)


Adding flags to caps is an interesting idea, we could also make
GstVideoInfo/GstAudioInfo add them automatically to cover most cases. The
question is just how the flags interact with all the caps operations. Do you
already have some ideas?

stream-start flags seem less complicated but I agree that it's more a format
specific thing than stream specific. Buffer flags seem like the worst option
and seem to have no advantage over any of the others other than making things
potentially more complicated :)


A property on basesink would also work for me, it seems like the safe and least
intrusive option. However having this information generally available in the
stream somehow seems useful on its own, not just for basesink.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.