[Bug 753265] Add device provider support for osx plugins

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753265

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326306|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 326306:
 --> (https://bugzilla.gnome.org/review?bug=753265&attachment=326306)

Mostly looks good to me, thanks! You might want to update your mail address in
the commit to your @igalia.com one though.

::: sys/osxaudio/gstosxaudiodeviceprovider.c
@@ +85,3 @@
+gst_osx_audio_device_provider_finalize (GObject * object)
+{
+  G_OBJECT_CLASS (gst_osx_audio_device_provider_parent_class)->finalize

No need for empty finalize functions

@@ +127,3 @@
+      kAudioDevicePropertyScopeInput;
+
+  AudioObjectPropertyAddress deviceNameAddress = {

We only allow declarations at the top of a block, not after some code

@@ +306,3 @@
+gst_osx_audio_device_finalize (GObject * object)
+{
+  G_OBJECT_CLASS (gst_osx_audio_device_parent_class)->finalize (object);

Can also go away because empty

@@ +338,3 @@
+      klass = "Audio/Source";
+
+      template_caps = gst_static_pad_template_get_caps (&src_factory);

Maybe we can reuse the pad templates from the elements here, and share them in
a common place instead of copying them?

@@ +383,3 @@
+  }
+
+  return;

No need for the empty returns here

::: sys/osxaudio/gstosxaudiodeviceprovider.h
@@ +32,3 @@
+
+G_BEGIN_DECLS
+    typedef struct _GstOsxAudioDeviceProvider GstOsxAudioDeviceProvider;

Indentation wrong :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.