[Bug 720659] avimux generates wrong 'blockalign'

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=720659

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
This causes regressions with MP2 at least, and is fixed by

commit e538608b3f90539003de21c1db238f3c9b946e30
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Wed Apr 27 14:09:03 2016 +0300

    avimux: Don't override maximum audio chunk size with the scale again just
before writing it

    set_fields() should only be called in the beginning, otherwise we will
never
    remember the maximum audio chunk size and write a wrong block align...
which
    then causes wrong timestamps and other problems.

commit 34dc1298e9c03a6f2f8f367b344b4c6525bd1d83
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Wed Apr 27 13:53:00 2016 +0300

    avimux: Actually store the largest audio chunk size for the VBR case of
MP2/MP3

    3ea338ce271e1f6a96d2ed49d4472b091f6f8b7e changed avimux to do that, but it
    never actually kept track of the max audio chunk for MP3 and MP2. These are
    knowing the hdr.scale only after parsing the frames instead of at setcaps
    time.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.