[Bug 765365] h264parse: Fails to parse HRD parameters in SPS that ffmpeg accepts just fine

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765365

--- Comment #10 from Nicola <lists at svrinformatica.it> ---
the macro READ_UE and READ_UINT8 have a goto error if parsing fails, maybe we
can create a new macro without the goto or use directly
nal_reader_get_ue/nal_reader_get_bits_uint8 inside the for, ignoring the errors
make the parser works properly, something like this (note the additional read):

for (sched_sel_idx = 0; sched_sel_idx <= hrd->cpb_cnt_minus1; sched_sel_idx++)
{
    //READ_UE (nr, hrd->bit_rate_value_minus1[sched_sel_idx]);
    nal_reader_get_ue (nr, &hrd->bit_rate_value_minus1[sched_sel_idx]);
    //READ_UE (nr, hrd->cpb_size_value_minus1[sched_sel_idx]);
    nal_reader_get_ue (nr, &hrd->cpb_size_value_minus1[sched_sel_idx]);
    READ_UINT8 (nr, hrd->cbr_flag[sched_sel_idx], 1);
    nal_reader_get_bits_uint8 (nr, &hrd->cbr_flag[sched_sel_idx], 1);
  }

are these fields optional?

For your info I reported the issue to the camera manufacter too

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.