[Bug 765729] qtdemux: Always set a group-id on STREAM_START

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Apr 28 14:50:20 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=765729

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326947|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 326947:
 --> (https://bugzilla.gnome.org/review?bug=765729&attachment=326947)

::: gst/isomp4/qtdemux.c
@@ +7345,3 @@
+      /* Get the group id from upstream, or create one */
+      if (!event || !gst_event_parse_group_id (event, &group_id))
+        group_id = gst_util_group_id_next ();

It should have the same group-id for all streams in the container, and only
increase the group id when the next container is played (i.e. forget it also
when going back from PAUSED to READY). That's why it was stored in the demuxer
struct before.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list