[Bug 758961] adaptivedemux: tests: do not sleep with the GST_TEST_LOCK taken

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758961

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326773|none                        |reviewed
             status|                            |

--- Comment #11 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 326773:
 --> (https://bugzilla.gnome.org/review?bug=758961&attachment=326773)

::: tests/check/elements/adaptive_demux_engine.c
@@ +167,3 @@
         priv->user_data);
   }
+  GST_TEST_UNLOCK (priv);

This means that actions done in appsink_event handler won't be able to cause
more events to be sent. A flushing seek, perhaps that would cause a flush-start
event would cause this to deadlock. It doesn't at the moment but it could cause
potential issues in the future.

I'd prefer for implementers of appsink_event to in their implementation use the
lock if they need.

@@ +193,1 @@


Same here for demux_sent_data

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.