[Bug 769390] wavparse: Add bitrate and container format tags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769390

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332487|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 332487:
 --> (https://bugzilla.gnome.org/review?bug=769390&attachment=332487)

::: gst/wavparse/gstwavparse.c
@@ +1228,2 @@
+    gst_tag_list_add (wav->tags, GST_TAG_MERGE_REPLACE,
+        GST_TAG_CONTAINER_FORMAT, "WAV", NULL);

Use gst_pb_utils_add_codec_description_to_tag_list() here. That ensures
consistent naming

@@ +1229,3 @@
+        GST_TAG_CONTAINER_FORMAT, "WAV", NULL);
+
+    if (wav->bps) {

How is this only for raw audio? And you can also add this for alaw/mulaw and a
few other codecs probably.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.