[Bug 769392] flacparse: add maximum bitrate tag

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Aug 2 06:27:59 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=769392

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332489|none                        |accepted-commit_now
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 332489:
 --> (https://bugzilla.gnome.org/review?bug=769392&attachment=332489)

::: gst/audioparsers/gstflacparse.c
@@ +1711,3 @@
+    gst_tag_list_add (flacparse->tags, GST_TAG_MERGE_KEEP,
+        GST_TAG_MAXIMUM_BITRATE, flacparse->samplerate * flacparse->bps *
+        flacparse->channels, NULL);

Is that so? The worst case should be even higher than that. But I guess this is
a valid guesstimate

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list