[Bug 769389] aiffparse: Add bitrate and container format tags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769389

--- Comment #4 from Carlos Rafael Giani <dv at pseudoterminal.org> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 332485 [details] [review]:
> 
> ::: gst/aiff/aiffparse.c
> @@ +1009,3 @@
> +
> +          /* Since this is uncompressed PCM data, the nominal
> +           *, actual, minimum, maximuzm bitrate are the same */
> 
> Typo here though.
> 
> Should make sure that whenever compressed support is added (aiff can do
> that, right?), we change this part here...

Yes, AIFF-C supports compression. However, aiffparse only supports uncompressed
PCM data. From gst_aiff_parse_parse_comm():

    /* We only support the 'trivial' uncompressed AIFC, but it can be
     * either big or little endian */

Adding support for alaw/mulaw/adpcm and others would perhaps be better kept in
a separate commit. Nevertheless, I'll modify the bitrate comment above to
reflect the AIFF-C situation.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.