[Bug 769293] vaapi/gl : Uploading to GL texture optimization

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769293

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332333|none                        |reviewed
             status|                            |

--- Comment #3 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 332333:
 --> (https://bugzilla.gnome.org/review?bug=769293&attachment=332333)

Looks good.  With the warning, it's good to go.

::: gst-libs/gst/gl/gstglupload.c
@@ +882,3 @@
+  if (gst_buffer_pool_acquire_buffer (upload->pool, outbuf,
+          NULL) != GST_FLOW_OK)
+    return GST_GL_UPLOAD_ERROR;

Add a warning here about acquire failing.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.