[Bug 769390] wavparse: Add bitrate and container format tags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769390

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332507|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 332507:
 --> (https://bugzilla.gnome.org/review?bug=769390&attachment=332507)

::: gst/wavparse/gstwavparse.c
@@ +1225,3 @@
     wav->got_fmt = TRUE;

+    wav->tags = gst_tag_list_new_empty ();

Check if a) anything could already have created ->tags before, and b) if all
other code works fine with you creating them here (i.e. nothing unconditionally
puts a new taglist here, like line 1227).

(Same thing for aiffparse)

@@ +1231,3 @@
+      gst_pb_utils_add_codec_description_to_tag_list (wav->tags,
+          GST_TAG_CONTAINER_FORMAT, desccaps);
+      gst_caps_unref (desccaps);

gst_pad_get_pad_template_caps() on the sinkpad, no need to create new caps
here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.