[Bug 755632] Memory leak in handle_setup_request

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Aug 2 14:19:12 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=755632

--- Comment #13 from Kseniya Vasilchuk <vasilchukkseniia at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #12)
> Comment on attachment 332546 [details] [review]
> rtsp-client: Fix leaking of session in error cases
> 
> Attachment 332546 [details] pushed as 687301a - rtsp-client: Fix leaking of
> session in error cases

I'm sure your commit is useful but the initial report was about GstRTSPMedia
objects memory leak... and it still here. You can check it like suggested in
Nikita's comment #5.

My patch resolved the problem at least for me.

What about Nikita Bobkov patch I think it is OK too, but for 1.4.5 version. The
reason why it failed in new version test suits is that it causes one more unref
than needed in the case of 'unsupported_client_transport'. At 1.4.5 version
'unsupported_client_transport' label with 'cleanup_transport' label inside it
was before last media object unref.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list