[Bug 769449] queue2: Add higher-resolution low/high-watermark properties

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769449

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332596|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 332596:
 --> (https://bugzilla.gnome.org/review?bug=769449&attachment=332596)

Generally looks good to me but all the renaming makes this change look huge and
will make things more difficult (like merge conflict in private branches, git
blame, etc)

::: plugins/elements/gstqueue2.c
@@ +388,1 @@
           G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

There's G_PARAM_DEPRECATED

@@ +940,1 @@
+  return MIN (buf_level, MAX_BUF_LEVEL);

Why all these changes in this function? Only needed change here is replacing
100 with MAX_BUF_LEVEL

@@ +943,2 @@
 static gboolean
+get_rel_buf_level (GstQueue2 * queue, gboolean * is_buffering, gint *
buf_level)

Why all this renaming? :) Basically it's exactly the same function as before,
just you changed all variable names

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.