[Bug 741104] dashdemux: add support for I frame based trick play

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Aug 5 08:54:59 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=741104

--- Comment #60 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
For streams using sidx, you also have to revert this revert:
https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=aea2c13fc1672a7260679d706d0a084a34ba7531

Other than what the commit message says, the commit is correct from my current
understanding. Just the unit test is wrong: it claims to pass dash with mp4 and
sidx to the demuxer, but the actual media is random bytes. As such when we use
the fragment info from the sidx (which we should as the manifest might not
contain anything at all, always sending us back to 0 on seeks) we would have no
info and go to the inaccurate fallback case.
IMHO these unit tests should be disabled until they produce valid data, or
completely replaced with validate tests on real streams. As they're now they
make no sense and only work because of how the demuxer currently works exactly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list