[Bug 769698] New: rtspserver: lack of support for rtcp-fb attributes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769698

            Bug ID: 769698
           Summary: rtspserver: lack of support for rtcp-fb attributes
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-rtsp-server
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: tomasz.zajac at motorolasolutions.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 333045
  --> https://bugzilla.gnome.org/attachment.cgi?id=333045&action=edit
Set of patches

There is no implementation for rtcp-fb-nack-pli and rtcp-fb-ccm-fir (rfc5104)
in both RTSP client and server. I have implemented it in following patches:

1) 0001-Parse-rtcp-fb-media-attributes.patch (sdpmessage, for rtsp client)
Adds parsing a=rtcp-fb SDP media attributes into relevant RTP CAPS (like
rtcp-fb-nack-pli)
See: https://bugzilla.gnome.org/show_bug.cgi?id=769628

2) 0001-Add-rtcp-fb-SDP-attributes-based-on-caps.patch (rtsp-server)
Adds rtcp-fb media attributes based on RTP CAPS.

3) 0001-gstrtpvp8pay-add-rtcp-fb-nack-pli-recp-fb-ccm-fir.patch (rtpvp8pay)
Adds rtcp-fb-nack-pli and rtcp-fb-ccm-fir into vp8 payloader. Similiar patches
are needed for other codes, perhaps it should be implemented in RTP payloader
base class.

With above set of patches user is able to create end-to-end RTSP connection
with correctly working nack-pli with VP8 codec. Since I am relatively new to
gstreamer, I am not sure how my changes fit into architecture and whether it is
a desired way of implementing it.
Alternatively I was thinking about adding new property to RTSPMediaFactory to
control adding these SDP attributes, but I guess that looking for this in CAPS
is cleaner.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.