[Bug 769717] h265parser: refactoring some methods to be more like h264parser

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769717

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #333081|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 333081:
 --> (https://bugzilla.gnome.org/review?bug=769717&attachment=333081)

Generally looks good but seems incomplete:

::: gst/videoparsers/gsth265parse.c
@@ -488,1 @@
 gst_h265_parse_process_nal (GstH265Parse * h265parse, GstH265NalUnit * nalu)

There are more callers of this function, where you probably want to check
return values. But it's the same in h264parse, which you probably want to
change at the same time then.

@@ -973,3 @@
-        nalu.type == GST_H265_NAL_PPS ||
-        (h265parse->have_sps && h265parse->have_pps)) {
-      gst_h265_parse_process_nal (h265parse, &nalu);

I think the intention here is that we skip all data except for the 3 headers in
the beginning, and only after SPS/PPS are there we process everything else

This was changed in h264parse for
https://bugzilla.gnome.org/show_bug.cgi?id=732203 in
34c2cfd4ddcc370a273d5c86d403e421a94d0157 , so should be fine here for the same
reasons

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.