[Bug 769717] h265parser: refactoring some methods to be more like h264parser

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Aug 12 14:01:22 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=769717

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #333135|none                        |reviewed
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 333135:
 --> (https://bugzilla.gnome.org/review?bug=769717&attachment=333135)

::: gst/videoparsers/gsth265parse.c
@@ -972,3 @@
-        nalu.type == GST_H265_NAL_SPS ||
-        nalu.type == GST_H265_NAL_PPS ||
-        (h265parse->have_sps && h265parse->have_pps)) {

This code makes it look like the VPS is optional, your changes assume it is
mandatory. Which one is correct?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list