[Bug 769802] queue2: Post buffering messages earlier in ringbuffer mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769802

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.9.2

--- Comment #2 from Edward Hervey <bilboed at bilboed.com> ---
commit 5154dcfbdc582e7491a14fbfa98cc79c222a0a81
Author: Edward Hervey <edward at centricular.com>
Date:   Fri Aug 12 16:15:25 2016 +0200

    queue2: Post buffering messages earlier in ringbuffer mode

    In ringbuffer mode we need to make sure we post buffering messages *before*
    blocking to wait for data to be drained.

    Without this, we would end up in situations like this:
    * pipeline is pre-rolling
    * Downstream demuxer/decoder has pushed data to all sinks, and demuxer
thread
      is blocking downstream (i.e. not pulling from upstream/queue2).
    * Therefore pipeline has pre-rolled ...
    * ... but queue2 hasn't filled up yet, therefore the application waits for
      the buffering 100% messages before setting the pipeline to PLAYING
    * But queue2 can't post that message, since the 100% message will be posted
      *after* there is room available for that last buffer.

    https://bugzilla.gnome.org/show_bug.cgi?id=769802

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.