[Bug 769972] rtpbin: remove arbitrary cutoff to not update ts-offset

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769972

Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vincent.penquerch at collabora
                   |                            |.co.uk

--- Comment #1 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
This is really to ask for feedback from someone who knows RTP.

I received a log from a client where this limit would trigger, and A/V would
keep out of sync.

Looking at the logs, we have a jitterbuffer log a bit before where the skew is
set, with a bit more than 3 seconds:
   rtpjitterbuffer rtpjitterbuffer.c:487:calculate_skew:<unknown> delta - skew:
0:00:03.097799643 too big, reset skew
   rtpjitterbuffer rtpjitterbuffer.c:487:calculate_skew:<unknown> delta - skew:
0:00:03.089132521 too big, reset skew

In turn, this will cause rtpbin to not update ts-offset.

Looking at git history, this cutoff seems totally arbitrary (introduced in
93228ccd525f318fa1ad633ed28c5a728b5740ef).

I just don't know much about RTP and whether this limit needs to exist at all
to prevent some other undesirable behavior (I don't understand what these
deltas are in the first place either).

Alternatively, I could add a property for this, defaulting to 3 seconds.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.