[Bug 769768] rtpjitterbuffer: lots of improvements around RTX

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769768

--- Comment #15 from Håvard Graff (hgr) <havard.graff at gmail.com> ---
(In reply to Olivier Crête from comment #13)
> Review of attachment 333139 [details] [review]:
> 
> I'd also suggest the patch title to be something like "rtpjitterbuffer:
> Collect stats for unsuccessful packets"

The patch does a whole lot more then just waiting for the rtx that did not
arrive in time, if you look through the tests we wrote for this. We did however
not find a proper way to split it up further since the changes are quite
substantial, and hence the name.

> 
> ::: gst/rtpmanager/gstrtpjitterbuffer.c
> @@ +718,3 @@
> +   * The time to wait for a retransmitted packet after it has been
> +   * considered lost in order to collect RTX statistics.
> +   *
> 
> Please specify the unit !

It is specified in the property, but I can add it there as well.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.