[Bug 770079] New: GST_PARAM_USER_SHIFT should represent minimum shift count

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770079

            Bug ID: 770079
           Summary: GST_PARAM_USER_SHIFT should represent minimum shift
                    count
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: All
            Status: NEW
          Severity: major
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: hfink at toolsonair.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 333552
  --> https://bugzilla.gnome.org/attachment.cgi?id=333552&action=edit
Do not shift GST_PARAM_USER_SHIFT

The following code would rightfully result in a compiler warning: 

#define    TME_API_PARAM_EXPOSED    (1 << (GST_PARAM_USER_SHIFT + 1))

warning: shift count >= width of type [-Wshift-count-overflow]
    if ((pspec->flags & TME_API_PARAM_EXPOSED) == 0)
                        ^~~~~~~~~~~~~~~~~~~~~
... because GST_PARAM_USER_SHIFT is already a shifted high integer value. See
attached patch for a fix to restore the expected behavior of
GST_PARAM_USER_SHIFT.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.