[Bug 755481] speex: handle streamheaders in caps/buffers better

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755481

--- Comment #4 from Håvard Graff (hgr) <havard.graff at gmail.com> ---
(In reply to Tim-Philipp Müller from comment #3)
> Created attachment 334055 [details] [review]
> patch that doesn't depend on other bug
> 
> Here's a patch for this that doesn't depend on the other bug.
> 
> > The tests describe this better then I can :)
> 
> Please could you describe *how* this improves the streambuffer handling
> exactly, so people don't have to "reverse engineer" it from your patch and
> the tests? :)

There are 4 tests:

test_headers_in_caps: Checks that the decoder can decode the output from
speexenc, where the streamheaders are negotiated both through caps and as
buffers, and in that case speexdec will use the caps.

test_headers_in_buffers: Checks that the decoder can decode the output from
speexenc, where the caps is *not* available, so that the streamheaders has to
be negotiated through the buffers.

test_headers_not_in_buffers: Checks that the decoder can decode the output from
speexenc where we remove the first two streamheader-buffers, so that
negotiation has to rely purly on caps.

test_headers_from_flv: Check that the decoder can use the streamheaders coming
from flxdemux, and still decode the buffer.

So a thorough checks of speex and its handling of streamheaders, coming from
both caps and/or buffers.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.