[Bug 769449] queue2: Add higher-resolution low/high-watermark properties

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Aug 25 08:55:06 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=769449

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
commit db66cb51b38fbffc2e1fb336a9636b22ec0fe241
Author: Carlos Rafael Giani <dv at pseudoterminal.org>
Date:   Wed Aug 3 15:20:20 2016 +0200

    queue2: Add higher-resolution low/high-watermark properties

    low/high-watermark are of type double, and given in range 0.0-1.0. This
    makes it possible to set low/high watermarks with greater resolution,
    which is useful with large queue2 max sizes and watermarks like 0.5%.

    Also adding a test to check the fill and watermark level behavior.

    https://bugzilla.gnome.org/show_bug.cgi?id=769449

commit e0f1a9e618e16e887d1d2b94e52ba02ae316fd78
Author: Carlos Rafael Giani <dv at pseudoterminal.org>
Date:   Wed Aug 3 15:27:40 2016 +0200

    queue2: Distinguish between buffering percentage and buffering level

    To make the code clearer, and to facilitate future improvements, introduce
    a distinction between the buffering level and the buffering percentage.

    Buffering level: the queue's current fill level. The low/high watermarks
    are in this range.

    Buffering percentage: percentage relative to the low/high watermarks
    (0% = low watermark, 100% = high watermark).

    To that end, get_buffering_percent() is renamed to get_buffering_level(),
    and the code at the end that transforms to the buffering percentage is
    factored out into a new convert_to_buffering_percent() function. Also,
    the buffering level range is parameterized by adding a new constant called
    MAX_BUFFERING_LEVEL.

    https://bugzilla.gnome.org/show_bug.cgi?id=769449

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list