[Bug 770585] glupload: propose dma buffer pool upstream based on ion allocator

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770585

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #334412|none                        |needs-work
             status|                            |

--- Comment #3 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 334412:
 --> (https://bugzilla.gnome.org/review?bug=770585&attachment=334412)

Why is all this needed?  What's wrong with upstream setting all this
information?  What kind of elements are upstream?

::: gst-libs/gst/gl/gstglupload.c
@@ +849,2 @@
   /* This will eliminate most non-dmabuf out there */
+  if (!gst_is_dmabuf_memory (gst_buffer_peek_memory (buffer, 0))) {

What's the difference between this failure case and the raw data uploader?

@@ +980,3 @@
+#endif
+  if (!allocator) {
+    GST_WARNING ("New ion allocator failed.");

This warning will occur on all non-ion platforms.

@@ +990,3 @@
+    goto setup_failed;
+
+  gst_query_set_nth_allocation_pool (query, 0, pool, info.size, 1, 30);

Why were these numbers (1, 30) chosen?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.