[Bug 754230] qtdemux: support sparse time ranges in qtdemux without needing a seek for MSE

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754230

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #334238|none                        |reviewed
             status|                            |

--- Comment #28 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 334238:
 --> (https://bugzilla.gnome.org/review?bug=754230&attachment=334238)

::: gst/isomp4/qtdemux.c
@@ +3123,3 @@
+       * difference between decode_ts and timestamp, prefer the former */
+      if (!qtdemux->upstream_format_is_time
+          && abs (decode_ts - timestamp) >

That's not safe to do as both values are unsigned (also use ABS())

@@ +3124,3 @@
+      if (!qtdemux->upstream_format_is_time
+          && abs (decode_ts - timestamp) >
+          stream->samples[stream->n_samples - 1].duration) {

Why take the duration of the sample as a limit? Why not e.g. 1 second, 10
seconds, ...? :)

The difference between decode_ts and timestamp can easily be higher than the
duration because of frame reordering already, no?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.