[Bug 774811] vaapi: drm: cannot find render node in a hybrid graphics

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774811

--- Comment #17 from Stirling Westrup <swestrup at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #16)
> Review of attachment 341067 [details] [review]:
> 
> Thanks a lot!
> 
> Just a couple comments :)
> 
> ::: gst-libs/gst/vaapi/gstvaapidisplay_drm.c
> @@ +73,3 @@
> + */
> +static gchar **
> +vstrdupv (gchar *** paos, ...)
> 
> what about using GArray? It looks to me like the natural way to handle this.

Sure, that would work. I just wanted to make the smallest possible patch to
minimize the chance of breaking something, and this seemed smaller.
> 
> @@ +298,3 @@
> +        if (vaInitialize (va_dpy, &major_version,
> +                &minor_version) == VA_STATUS_SUCCESS) {
> +          vaTerminate (va_dpy);
> 
> here looks to me a memory leak, since the va_dpy is not vaTerminate if
> vaInitialize fails, but still there's a context allocated

Could be. A colleague gave me those lines, since I know libudev and glib, but
not libva.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.