[Bug 775132] adaptivedemux: Download fragment only for activated stream

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775132

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341108|none                        |needs-work
             status|                            |

--- Comment #4 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 341108:
 --> (https://bugzilla.gnome.org/review?bug=775132&attachment=341108)

Generally looks good - just the one comment below. One thing we might want to
do (but can do later) is sub-class GstStream to our own type, and then we can
keep a pointer to the adaptivedemux stream object directly. That will be useful
when receiving back the GstStream in a select-streams event from the app

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +1172,3 @@
+
+  stream->object = gst_stream_new (stream_id, NULL,
+      GST_STREAM_TYPE_CONTAINER, GST_STREAM_FLAG_NONE);

I'm not sure about using GST_STREAM_TYPE_CONTAINER here - no all sub-classes of
adaptivedemux output containers. HLS can output raw AAC, for example. It should
probably start as GST_STREAM_TYPE_UNKNOWN, and we modify it once we know the
caps (might need extra adaptivedemux API for that, or an extra argument on the
set_caps() function)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.