[Bug 769266] vaapi encoder should not accept all caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769266

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341133|none                        |rejected
             status|                            |

--- Comment #15 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 341133:
 --> (https://bugzilla.gnome.org/review?bug=769266&attachment=341133)

It doesn't compile :)

::: gst/vaapi/gstvaapiencode.c
@@ +355,3 @@
+    goto normal;
+
+  formats = gst_vaapi_encoder_get_surface_formats (encode->encoder);

I guess you missed something in your patch

gstvaapiencode.c:357:13: error: implicit declaration of function
'gst_vaapi_encoder_get_surface_formats'       is invalid in C99
[-Werror,-Wimplicit-function-declaration]                                      
   formats = gst_vaapi_encoder_get_surface_formats (encode->encoder);          
                                      ^                                        
                                                   gstvaapiencode.c:357:11:
error: incompatible integer to pointer conversion assigning to 'GArray *'      
      (aka 'struct _GArray *') from 'int' [-Werror,-Wint-conversion]           
                           formats = gst_vaapi_encoder_get_surface_formats
(encode->encoder);                                               ^
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.