[Bug 731780] rtpjitterbuffer: free item if it is a duplicated one

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Dec 2 10:52:20 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=731780

--- Comment #11 from Edward Hervey <bilboed at bilboed.com> ---
The change to apply to make it assert

@@ -3757,9 +3760,11 @@ do_lost_timeout (GstRtpJitterBuffer * jitterbuffer,
TimerData * timer,
             "retry", G_TYPE_UINT, num_rtx_retry, NULL));
   }
   item = alloc_item (event, ITEM_TYPE_LOST, -1, -1, seqnum, lost_packets, -1);
-  if (!rtp_jitter_buffer_insert (priv->jbuf, item, &head, NULL))
+  if (!rtp_jitter_buffer_insert (priv->jbuf, item, &head, NULL)) {
     /* Duplicate */
+    g_assert(FALSE);
     free_item (item);
+  }

   if (GST_CLOCK_TIME_IS_VALID (timer->rtx_last)) {
     /* Store info to update stats if the packet arrives too late */

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list