[Bug 775543] New: rtspsrc: redirect-on-play skips stream cleanup and TEARDOWN

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775543

            Bug ID: 775543
           Summary: rtspsrc: redirect-on-play skips stream cleanup and
                    TEARDOWN
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: staples255 at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 341287
  --> https://bugzilla.gnome.org/attachment.cgi?id=341287&action=edit
allow cleanup on redirect by leaving state changes to the redirect handlers

The fix for http://bugzilla.gnome.org/show_bug.cgi?id=772610 allows redirect to
happen in response to the PLAY command, but it's not performing the necessary
cleanup of the initial session.

The proposed fix is to simply remove the code in gst_rtspsrc_try_send that
changes the state to GST_RTSP_STATE_INIT when it sets need_redirect to TRUE. 
In the case of redirect-on-describe, the current state is actually still
GST_RTSP_STATE_INVALID when the redirect happens, so setting it to INIT seems
like a mistake.
In the case of redirect-on-play, the current state is GST_RTSP_STATE_READY, and
it needs to stay that way so that the subsequent call to gst_rtsp_close (from
gst_rtspsrc_play) knows what needs to be cleaned up.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.