[Bug 769266] vaapi encoder should not accept all caps

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Dec 5 16:01:50 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=769266

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341189|none                        |needs-work
             status|                            |

--- Comment #23 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 341189:
 --> (https://bugzilla.gnome.org/review?bug=769266&attachment=341189)

::: gst/vaapi/gstvaapiencode.c
@@ +372,3 @@
+  gst_caps_append (out_caps, gst_caps_copy (raw_caps));
+
+  gst_caps_replace (&plugin->sinkpad_caps, out_caps);

the idea of having the variable memeber sinkpad_caps is to avoids its
calculation as much as possible. This should be moved to a function that
validates it existence and return it, otherwise do this calculation.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list