[Bug 775727] buffer: add gst_buffer_iterate_meta_filtered() convenience function

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Dec 7 10:22:46 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=775727

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341513|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 341513:
 --> (https://bugzilla.gnome.org/review?bug=775727&attachment=341513)

Looks good to me

> Maybe it should be called iterate_meta_api() instead, dunno.

Then it would be iterating over meta APIs, not metas IMHO.
iterate_meta_filtered_by_api() could make sense but what else would you filter
on?

::: gst/gstbuffer.c
@@ +2279,3 @@
+ * gst_buffer_iterate_meta_filtered:
+ * @buffer: a #GstBuffer
+ * @state: an opaque state pointer

That should probably be marked as "out". Is this usable in bindings without
having some non-void typedef instead?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list