[Bug 754575] trick modes in gst-rtsp-server

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754575

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338323|none                        |reviewed
             status|                            |

--- Comment #24 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338323:
 --> (https://bugzilla.gnome.org/review?bug=754575&attachment=338323)

Generally looks good to me

::: gst/rtsp-server/rtsp-media.c
@@ +2191,1 @@
+  if (range != NULL) {

Maybe mention that we now allow range!=NULL for seeks to the same position that
just change e.g. the rate. In the commit message and a comment here

@@ +2214,3 @@
     stop_type = GST_SEEK_TYPE_SET;

+  trick_mode = flags != 0 || rate != 1.0;

Why is it trick_mode if flags != 0? GST_SEEK_FLAG_ACCURATE or
GST_SEEK_FLAG_FLUSH don't seem like trick modes

You probably also want to ensure that unsupported flags return in an error
here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.