[Bug 740432] valve drop=true doesn't allow EOS to flow downstream.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=740432

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
The problem with dropping EOS is, that after EOS nothing will ever come again
(except for maybe a flush). So when switching to drop=false after receiving
EOS, just nothing will happen (as nothing would trigger the EOS being sent
downstream).

It doesn't seem like a good design to always drop EOS here. Also always
dropping flushes does not seem ideal either: downstream might have data queued
from before the flush, then drop=false, then flush, then drop=true and
completely new data is sent that might cause confusion in combination with the
old data. Also while the direct downstream of valve might not be blocked, a
further downstream of it (after e.g. a queue) might be blocked regardless of
drop=true or not... and a flush would help getting this unblocked.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.