[Bug 773463] core(debug): hard to distinguish related log at multi-instance env

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773463

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341558|none                        |reviewed
             status|                            |

--- Comment #13 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> ---
Review of attachment 341558:
 --> (https://bugzilla.gnome.org/review?bug=773463&attachment=341558)

::: gst/gstobject.c
@@ +166,3 @@
+  if (object_repr_level <= 0) {
+    if (self->name)
+  gchar *repr = NULL;

either use self->name in g_strdup_printf() or
const gchar* name = GST_OBJECT_NAME (self);
if (name)
  return g_strdup_printf ("<%s>", name);
...

@@ +174,3 @@
+  if (self->priv->path)
+    repr = g_strdup_printf ("<%s>", priv->path);
+    if (self->name)

priv->toplevel
also next line

@@ +181,3 @@
+  else
+    repr = g_strdup_printf ("<%s@%p>", G_OBJECT_TYPE_NAME (self), self);
+  }

please either add {} or leave them out

@@ +208,3 @@
+    g_mutex_lock (&priv->repr_lock);
+    if (!toplevel)
+

does this need to be in the lock'ed section

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.