[Bug 775794] qtdemux: can not play xvid/mp2 quicktime format

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775794

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341603|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 341603:
 --> (https://bugzilla.gnome.org/review?bug=775794&attachment=341603)

Generally looks good

::: gst/isomp4/qtdemux.c
@@ +7230,3 @@
       {
         const guint8 *buf;
         guint32 version;

The code below looks rather... broken. First the FIXME comment, then it also
misses length checks to see if it actually has enough data available to parse
there (which looks both potentially security relevant).

Maybe you can look into that in addition to this patch (as a separate patch)?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.