[Bug 775921] multiqueue: Fix overflow on get_buffering_level()

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Dec 10 10:45:22 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=775921

--- Comment #3 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 341712:
 --> (https://bugzilla.gnome.org/review?bug=775921&attachment=341712)

::: plugins/elements/gstmultiqueue.c
@@ +1134,3 @@
     if (sq->max_size.time > 0) {
       tmp =
+          gst_util_uint64_scale (sq->cur_time,

I think this line is the only actually needed change - because it's passing
sq->max_size.time as a gint to gst_util_uint64_scale_int(). The result of
gst_util_uint64_scale() should fit in an int just fine and gets truncated to
that before returning anyway.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list