[Bug 774587] msdk: add decoder

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774587

Josep Torra Valles <n770galaxy at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341510|none                        |needs-work
             status|                            |

--- Comment #6 from Josep Torra Valles <n770galaxy at gmail.com> ---
Review of attachment 341510:
 --> (https://bugzilla.gnome.org/review?bug=774587&attachment=341510)

::: sys/msdk/gstmsdkdec.c
@@ +163,3 @@
+}
+
+static GstFlowReturn gst_msdkdec_drain (GstVideoDecoder * decoder);

Please reorder the code to avoid this forward declaration.

@@ +166,3 @@
+
+static void
+gst_msdkdec_set_property (GObject * object, guint prop_id, const GValue *
value,

My preference and to be more consistent with the encoder base class is to have
gobject overrides, _set_property, _get_property and _finalize, at the bottom
just before the class_init.

::: sys/msdk/gstmsdkdec.h
@@ +81,3 @@
+  GstVideoDecoderClass parent_class;
+
+    gboolean (*set_format) (GstMsdkDec * decoder);

This vmethod is not used, maybe just drop it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.