[Bug 774600] omx: Pipeline premature EOS after discontinuity on lossy transport stream

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774600

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341779|none                        |reviewed
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 341779:
 --> (https://bugzilla.gnome.org/review?bug=774600&attachment=341779)

Is this maybe related to https://bugzilla.gnome.org/show_bug.cgi?id=741856 ?

::: omx/gstomx.c
@@ +1263,3 @@
   if (port->flushing) {
+    GST_DEBUG_OBJECT (comp->parent, "Component %s port %d is flushing",
+        comp->name, port->index);

Can you put all the new debug output into a separate patch? That would
definitely be good and useful to merge ASAP

@@ +1333,2 @@
     ret = GST_OMX_ACQUIRE_BUFFER_EOS;
+    port->eos = FALSE;

How would that help here? We would return EOS from acquire_buffer, which would
shut down the caller. And if it doesn't, we would call back in here again and
wait forever (the component usually gives you nothing new after EOS).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.