[Bug 775965] ttmlparse: Collect buffers until detecting complete xml document

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775965

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341788|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 341788:
 --> (https://bugzilla.gnome.org/review?bug=775965&attachment=341788)

::: ext/ttml/gstttmlparse.c
@@ +438,3 @@
+        G_GSIZE_FORMAT, avail);
+    return;
+  }

Instead of trying to parse the document every time (which is expensive), it
would be better to just check the starting and closing XML tag. Especially that
would then also work if you get *multiple* documents in a single buffer (in
which case you would have to split).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.