[Bug 775794] qtdemux: can not play xvid/mp2 quicktime format

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775794

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 341603:
 --> (https://bugzilla.gnome.org/review?bug=775794&attachment=341603)

::: gst/isomp4/qtdemux.c
@@ +13789,3 @@
           "mpegversion", G_TYPE_INT, 1, NULL);
       break;
+    case GST_MAKE_FOURCC ('.', 'm', 'p', ' 2'):

There's a typo here, fixed that before merging

qtdemux.c: In function ‘qtdemux_audio_caps’:
gstreamer/gst/gstvalue.h:45:74: error: result of ‘8242 << 24’ requires 39 bits
to represent, but ‘int’ only has 32 bits [-Werror=shift-overflow=]
 #define GST_MAKE_FOURCC(a,b,c,d)       
((guint32)((a)|(b)<<8|(c)<<16|(d)<<24))
                                                                          ^
qtdemux.c:13775:10: note: in expansion of macro ‘GST_MAKE_FOURCC’
     case GST_MAKE_FOURCC ('.', 'm', 'p', ' 2'):
          ^~~~~~~~~~~~~~~

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.