[Bug 774409] tests/jitterbuffer: Major refactoring and cleanups

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Dec 14 13:01:02 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=774409

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
commit 0a81f71df5aa15627eb9f1756c92eabe5d3aa38c
Author: Havard Graff <havard.graff at gmail.com>
Date:   Wed Dec 14 10:39:12 2016 +0100

    tests/jitterbuffer: Major refactoring and cleanups

    * Changed PCMU->TEST for common macros
    * Changed verify-functions (lost & rtx) into macros.
    * Remove option to add marker-bit for test-buffers (not used anywhere)
    * Add new push_test_buffer function that makes sure there are correlation
      between dts and the time on the clock. (classic test-mistake)
    * Established a generic starting-point for tests with the
      construct_deterministic_initial_state function and use it where
      applicable, which removes lots of "boilerplate" everywhere.
    * Add basic lost-event test
    * Remove as much "magic constants" as possible.
    * Remove 3 tests that no longer are testing anything that others don't,
      and was completely unmaintainable.
    * Remove unnecessary use of the testclock
    * Verify each test is testing what it actually says it does (and modify
      where it doesn't)

    In general, make the tests much smaller, better, more maintainable and
    readable.

    https://bugzilla.gnome.org/show_bug.cgi?id=774409

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list