[Bug 776125] fix an use after free in gst_base_sink_send_event()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776125

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342006|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 342006:
 --> (https://bugzilla.gnome.org/review?bug=776125&attachment=342006)

::: libs/gst/base/gstbasesink.c
@@ +4504,2 @@
   GST_DEBUG_OBJECT (basesink, "handled event %p %" GST_PTR_FORMAT ": %d",
event,
       event, result);

The nicer solution would be, to move this debug output before the
gst_pad_push() (without the result of course, and saying "sending" instead of
"handled"). And then having another here that just says "handled event: %",
result

That way the event is possibly writeable by downstream and we don't keep
another reference to it

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.