[Bug 775948] [Patch] omxvideodec: Support for egl_render on RPi breaks dynamic resolution changes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775948

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342183|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 342183:
 --> (https://bugzilla.gnome.org/review?bug=775948&attachment=342183)

::: omx/gstomxvideodec.c
@@ -967,3 @@
-
-        /* fallback: try to use EGLImage even if it is not in the caps feature
*/
-        if (!gst_video_decoder_negotiate (GST_VIDEO_DECODER (self))) {

If I'm not missing anything, this fallback case is missing now? Shouldn't it
try negotiating with EGLImage/RGBA first, and only if that fails fall back to
using no EGLImage as your patch does now?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.