[Bug 775962] Occassional addition of codec_data to caps when stream-format: byte-stream

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775962

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342181|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 342181:
 --> (https://bugzilla.gnome.org/review?bug=775962&attachment=342181)

::: omx/gstomxh264enc.c
@@ +553,3 @@
      * in the caps!
      */
+    caps = gst_pad_get_current_caps (GST_VIDEO_ENCODER_SRC_PAD (self));

Instead of parsing the caps on every codecconfig buffer, it would make more
sense to remember if it was byte-stream or not when the caps were set.

Otherwise makes sense

@@ +575,3 @@
+          memcpy (map.data,
+              buf->omx_buf->pBuffer + buf->omx_buf->nOffset,
+              buf->omx_buf->nFilledLen);

Could use gst_buffer_fill() here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.