[Bug 776200] dashdemux: Always parsing sidx for On-Demand profile

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776200

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342110|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 342110:
 --> (https://bugzilla.gnome.org/review?bug=776200&attachment=342110)

Looks generally good, thanks

::: ext/dash/gstdashdemux.c
@@ +706,3 @@
+      stream->is_isobmff =
+          gst_structure_has_name (s, "video/quicktime") ||
+          gst_structure_has_name (s, "audio/x-m4a");

audio/x-m4a is generally isobmff, so only considering this for ondemand profile
seems weird. While it's then unused for audio currently, this might change
later and cause problems here

@@ +1166,2 @@
     stream->fragment.uri = fragment.uri;
+    /* If mpd does not specify indexRagne (i.e., null index_uri),

Typo

@@ +2439,3 @@

+  if (dashdemux->allow_trickmode_key_units ||
+      gst_mpd_client_has_isoff_ondemand_profile (dashdemux->client)) {

&& !SIDX (dashstream)->entries maybe?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.