[Bug 776200] dashdemux: Always parsing sidx for On-Demand profile

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776200

--- Comment #6 from Seungha Yang <sh.yang at lge.com> ---
(In reply to Sebastian Dröge (slomo) from comment #4)
> Review of attachment 342110 [details] [review]:
> 
> Looks generally good, thanks
> 
> ::: ext/dash/gstdashdemux.c
> @@ +706,3 @@
> +      stream->is_isobmff =
> +          gst_structure_has_name (s, "video/quicktime") ||
> +          gst_structure_has_name (s, "audio/x-m4a");
> 
> audio/x-m4a is generally isobmff, so only considering this for ondemand
> profile seems weird. While it's then unused for audio currently, this might
> change later and cause problems here

I modified the condition there.

> @@ +2439,3 @@
>  
> +  if (dashdemux->allow_trickmode_key_units ||
> +      gst_mpd_client_has_isoff_ondemand_profile (dashdemux->client)) {
> 
> && !SIDX (dashstream)->entries maybe?

Checking GST_ISOFF_SIDX_PARSER_FINISHED seems to be more straightforward and
readable :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.