[Bug 749567] tcpclientsrc: add timeout property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749567

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304578|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 304578:
 --> (https://bugzilla.gnome.org/review?bug=749567&attachment=304578)

Generally looks good, just some minor things

::: gst/tcp/gsttcpclientsrc.c
@@ +33,3 @@
  * gst-launch-1.0 tcpclientsrc port=3000 ! fdsink fd=2
+ * ]| everything you type in the server is shown on the client.
+ * If you want to detect network failures and/or limit the time your tcp
client keeps waiting for data from server setting a timeout value can be
useful.

You probably want to split this into multiple lines ;)

@@ +115,3 @@
+      g_param_spec_uint ("timeout", "timeout",
+          "Value in seconds to timeout a blocking I/O. 0 = No timeout. "
+          "(Since 1.6)", 0, G_MAXUINT, TCP_DEFAULT_TIMEOUT,

Since: 1.12, and this shouldn't be in the property description but as gtk-doc
documentation for the property

@@ +408,3 @@
     goto no_socket;

+  g_socket_set_timeout (src->socket, src->timeout);

Now socket operations will timeout. Should we handle the timeout error return
value specifically somehow?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.